Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stubsabot] Mark Flask-SQLAlchemy as obsolete since 3.0.1 #8849

Merged
merged 1 commit into from
Oct 12, 2022
Merged

[stubsabot] Mark Flask-SQLAlchemy as obsolete since 3.0.1 #8849

merged 1 commit into from
Oct 12, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2022 •
edited
Loading

@AlexWaygood AlexWaygood closed this Oct 4, 2022
@AlexWaygood AlexWaygood reopened this Oct 4, 2022
@AlexWaygood
Copy link
Member

https://twitter.com/davidism/status/1571559592638943232?s=20&t=LRADTGToyyoZoigxYix1jw

Completely refactored Flask-SQLAlchemy, rewrote all the docs and tests, added static types, implemented metadata-per-bind, closed 41 issues and 12 PRs, made 27 commits over 1 month, 60 files changed.

@AlexWaygood
Copy link
Member

  • 21 public Python files have been added.
  • 3 files included in typeshed's stubs have been deleted: flask_sqlalchemy/__init__.py, flask_sqlalchemy/model.py, flask_sqlalchemy/utils.py.
  • 0 files included in typeshed's stubs have been modified or renamed.

This analysis is screwed up because Flask-SQLAchemy changed its directory structure between the two releases. The package used to be in a flask_sqlalchemy directory; it's now in a src/flask_sqlalchemy directory.

I'm not sure I know of a good way to detect that kind of thing; and I think the existing logic will still give a pretty good analysis most of the time.

@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood AlexWaygood added the help wanted An actionable problem of low to medium complexity where a PR would be very welcome label Oct 4, 2022
@AlexWaygood AlexWaygood mentioned this pull request Oct 4, 2022
Closed
@AlexWaygood
Copy link
Member

The latest release ships with inline type annotations, but the maintainer is unwilling to add a py.typed file, which is reasonable: pallets-eco/flask-sqlalchemy#1112 (comment).

So we won't be able to mark these stubs as obsolete yet (but the inline types should help us substantially in updating our stubs.)

@JelleZijlstra JelleZijlstra force-pushed the stubsabot/flask-sqlalchemy branch from e5c0c75 to b21065a Compare October 5, 2022 18:40
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra JelleZijlstra force-pushed the stubsabot/flask-sqlalchemy branch from b21065a to f00cd05 Compare October 6, 2022 00:17
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood AlexWaygood marked this pull request as draft October 6, 2022 00:36
@AlexWaygood
Copy link
Member

The latest release ships with inline type annotations, but the maintainer is unwilling to add a py.typed file, which is reasonable: pallets-eco/flask-sqlalchemy#1112 (comment).

So we won't be able to mark these stubs as obsolete yet (but the inline types should help us substantially in updating our stubs.)

Looks like this has been reconsidered, and that the library will shortly be marked as py.typed: pallets-eco/flask-sqlalchemy#1112 (comment).

@AlexWaygood AlexWaygood added status: DO NOT MERGE and removed help wanted An actionable problem of low to medium complexity where a PR would be very welcome labels Oct 6, 2022
@davidism
Copy link

Just released Flask-SQLAlchemy 3.0.1 with a py.typed marker.

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 11, 2022 •
edited
Loading

Just released Flask-SQLAlchemy 3.0.1 with a py.typed marker.

Thanks @davidism!

Hopefully our stubsabot bot will auto-update this PR at midnight UTC (this PR is a good test case for some recent updates we've made to the bot).

@github-actions github-actions bot changed the title [stubsabot] Bump Flask-SQLAlchemy to 3.0.* [stubsabot] Mark Flask-SQLAlchemy as obsolete since 3.0.1 Oct 12, 2022
@JelleZijlstra JelleZijlstra force-pushed the stubsabot/flask-sqlalchemy branch from f00cd05 to 67dbd23 Compare October 12, 2022 00:19
@AlexWaygood AlexWaygood marked this pull request as ready for review October 12, 2022 00:21
@AlexWaygood AlexWaygood mentioned this pull request Oct 12, 2022
Merged
@github-actions
Copy link
Contributor Author

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 1894ee9 into master Oct 12, 2022
@AlexWaygood AlexWaygood deleted the stubsabot/flask-sqlalchemy branch October 12, 2022 00:30
@AlexWaygood
Copy link
Member

#8885 to track removal of the stubs from typeshed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @davidism